git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 04/10] add_sought_entry_mem: convert to struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jun 13, 2015, 22:16 UTC
Message-ID
<1434233803-422442-5-git-send-email-sandals@crustytoothpaste.net>
In-Reply-To
<1434233803-422442-1-git-send-email-sandals@crustytoothpaste.net>

Convert this function to use struct object_id. Express several hardcoded constants in terms of GIT_SHA1_HEXSZ.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 builtin/fetch-pack.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index 19215b3..cf3019e 100644
--- a/builtin/fetch-pack.c
+++ b/builtin/fetch-pack.c
@@ -14,12 +14,14 @@ static void add_sought_entry_mem(struct ref ***sought, int *nr, int *alloc,
 				 const char *name, int namelen)
 {
 	struct ref *ref = xcalloc(1, sizeof(*ref) + namelen + 1);
-	unsigned char sha1[20];
+	struct object_id oid;
+	const int chunksz = GIT_SHA1_HEXSZ + 1;
 
-	if (namelen > 41 && name[40] == ' ' && !get_sha1_hex(name, sha1)) {
-		hashcpy(ref->old_oid.hash, sha1);
-		name += 41;
-		namelen -= 41;
+	if (namelen > chunksz && name[chunksz - 1] == ' ' &&
+		!get_oid_hex(name, &oid)) {
+		oidcpy(&ref->old_oid, &oid);
+		name += chunksz;
+		namelen -= chunksz;
 	}
 
 	memcpy(ref->name, name, namelen);
-- 
2.4.0
Previous: Junio C HamanoNext: brian m. carlson
Message 6 of 13 in “object_id part 2”
  1. 00/10 object_id part 2brian m. carlson, Jun 13, 2015
  2. 01/10 refs: convert some internal functions to use object_idbrian m. carlson, Jun 13, 2015
  3. 02/10 sha1_file: introduce has_object_file helper.brian m. carlson, Jun 13, 2015
  4. 03/10 Convert struct ref to use object_id.brian m. carlson, Jun 13, 2015
  5. Junio C HamanoJun 15, 2015
  6. 04/10 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Jun 13, 2015
  7. 05/10 parse_fetch: convert to use struct object_idbrian m. carlson, Jun 13, 2015
  8. 06/10 get_remote_heads: convert to struct object_idbrian m. carlson, Jun 13, 2015
  9. 07/10 push_refs_with_export: convert to struct object_idbrian m. carlson, Jun 13, 2015
  10. 08/10 ref_newer: convert to use struct object_idbrian m. carlson, Jun 13, 2015
  11. 10/10 remote: convert functions to struct object_idbrian m. carlson, Jun 13, 2015
  12. Michael HaggertyAug 2, 2015
  13. brian m. carlsonAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.