git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] object_id part 2

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jun 13, 2015, 08:45 UTC
Message-ID
<557BEDA9.30809@alum.mit.edu>
In-Reply-To
<20150612222713.GD29305@vauxhall.crustytoothpaste.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/13/2015 12:27 AM, brian m. carlson wrote:
Show 22 quoted lines
> On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> 
>>> While I did run the tests between each commit, I hadn't noticed
>>> they were failing because I don't have Apache installed on my
>>> laptop, so they were silently skipped.  I'll resubmit with that
>>> fixed.
>> 
>> It is somewhat strange that _only_ http part had failures like
>> this, and is unnerving, too, given that a few people seem to have
>> given at least a cursory read over the patches and didn't spot
>> anything obviously wrong.
>> 
>> Was that because there was a single manual botch, or was that
>> merely that other parts of the system do not have sufficient test
>> coverage?
> 
> It appears that I broke the change in "parse_fetch: convert to use 
> struct object_id" which modifies remote-curl.c, so I think it's a
> single manual botch.  I'm going to rework that patch anyway since
> Michael said that he didn't like the idea of parse_oid_hex as it
> stands, so it will end up being mostly moot.

In the same email where I made those design suggestions, I also I pointed out a bug in the implementation of parse_oid_hex(). Maybe that is the reason for the test failures.

Michael
- -- 
Michael Haggerty
mhagger@alum.mit.edu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlV77aYACgkQwg9mrRwfmAnCyQCeIp9aSOTtQ1ABpiSybcFQFP87 fNwAoLNhQtyFQ2/fqQIvzl1gGEEOlWxa =gI7/ -----END PGP SIGNATURE-----

Previous: brian m. carlsonNext: brian m. carlson
Message 22 of 23 in “object_id part 2”
  1. 0/8 object_id part 2brian m. carlson, Jun 9, 2015
  2. 1/8 refs: convert some internal functions to use object_idbrian m. carlson, Jun 9, 2015
  3. 2/8 sha1_file: introduce has_object_file helper.brian m. carlson, Jun 9, 2015
  4. Duy NguyenJun 10, 2015
  5. brian m. carlsonJun 10, 2015
  6. 3/8 Convert struct ref to use object_id.brian m. carlson, Jun 9, 2015
  7. Michael HaggertyJun 11, 2015
  8. 4/8 Add a utility function to make parsing hex values easier.brian m. carlson, Jun 9, 2015
  9. Michael HaggertyJun 11, 2015
  10. 5/8 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Jun 9, 2015
  11. 6/8 parse_fetch: convert to use struct object_idbrian m. carlson, Jun 9, 2015
  12. 7/8 ref_newer: convert to use struct object_idbrian m. carlson, Jun 9, 2015
  13. Junio C HamanoJun 10, 2015
  14. brian m. carlsonJun 10, 2015
  15. brian m. carlsonJun 11, 2015
  16. Junio C HamanoJun 11, 2015
  17. brian m. carlsonJun 11, 2015
  18. Junio C HamanoJun 11, 2015
  19. brian m. carlsonJun 12, 2015
  20. Junio C HamanoJun 12, 2015
  21. brian m. carlsonJun 12, 2015
  22. Michael HaggertyJun 13, 2015
  23. brian m. carlsonJun 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.