git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] object_id part 2

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jun 12, 2015, 22:27 UTC
Message-ID
<20150612222713.GD29305@vauxhall.crustytoothpaste.net>
In-Reply-To
<xmqqvbesbmm6.fsf@gitster.dls.corp.google.com>
On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > While I did run the tests between each commit, I hadn't noticed they
> > were failing because I don't have Apache installed on my laptop, so they
> > were silently skipped.  I'll resubmit with that fixed.
> 
> It is somewhat strange that _only_ http part had failures like this,
> and is unnerving, too, given that a few people seem to have given at
> least a cursory read over the patches and didn't spot anything
> obviously wrong.
> 
> Was that because there was a single manual botch, or was that merely
> that other parts of the system do not have sufficient test coverage?

It appears that I broke the change in "parse_fetch: convert to use struct object_id" which modifies remote-curl.c, so I think it's a single manual botch. I'm going to rework that patch anyway since Michael said that he didn't like the idea of parse_oid_hex as it stands, so it will end up being mostly moot.

I mostly introduced it in an effort to avoid having to use GIT_SHA1_HEXSZ repeatedly throughout small blocks of code, but since we don't use assignments in conditionals, it doesn't seem useful as it currently stands.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Junio C HamanoNext: Michael Haggerty
Message 21 of 23 in “object_id part 2”
  1. 0/8 object_id part 2brian m. carlson, Jun 9, 2015
  2. 1/8 refs: convert some internal functions to use object_idbrian m. carlson, Jun 9, 2015
  3. 2/8 sha1_file: introduce has_object_file helper.brian m. carlson, Jun 9, 2015
  4. Duy NguyenJun 10, 2015
  5. brian m. carlsonJun 10, 2015
  6. 3/8 Convert struct ref to use object_id.brian m. carlson, Jun 9, 2015
  7. Michael HaggertyJun 11, 2015
  8. 4/8 Add a utility function to make parsing hex values easier.brian m. carlson, Jun 9, 2015
  9. Michael HaggertyJun 11, 2015
  10. 5/8 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Jun 9, 2015
  11. 6/8 parse_fetch: convert to use struct object_idbrian m. carlson, Jun 9, 2015
  12. 7/8 ref_newer: convert to use struct object_idbrian m. carlson, Jun 9, 2015
  13. Junio C HamanoJun 10, 2015
  14. brian m. carlsonJun 10, 2015
  15. brian m. carlsonJun 11, 2015
  16. Junio C HamanoJun 11, 2015
  17. brian m. carlsonJun 11, 2015
  18. Junio C HamanoJun 11, 2015
  19. brian m. carlsonJun 12, 2015
  20. Junio C HamanoJun 12, 2015
  21. brian m. carlsonJun 12, 2015
  22. Michael HaggertyJun 13, 2015
  23. brian m. carlsonJun 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.