Re: [PATCH v2] t7510: do not fail when gpg warns about insecure memory
Kyle J. McKay venit, vidit, dixit 09.03.2015 21:03:
Show 15 quoted lines
> Depending on how gpg was built, it may issue the following
> message to stderr when run:
>
> Warning: using insecure memory!
>
> When the test is collecting gpg output it is therefore not
> enough to just match on a "gpg: " prefix it must also match
> on a "Warning: " prefix wherever it needs to match lines
> that have been produced by gpg.
>
> Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
> ---
>
> How about this patch instead. It just treats "Warning:" lines as gpg
> output
(They are, but gpg fails tp prefix them.)
> and the test still passes when "Warning: using insecure memory"
> shows up.
>
> -Kyle
Show 20 quoted lines
> t/t7510-signed-commit.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
> index 474dab38..3cef18cf 100755
> --- a/t/t7510-signed-commit.sh
> +++ b/t/t7510-signed-commit.sh
> @@ -86,8 +86,8 @@ test_expect_success GPG 'show signed commit with signature' '
> git show -s --show-signature initial >show &&
> git verify-commit -v initial >verify.1 2>verify.2 &&
> git cat-file commit initial >cat &&
> - grep -v "gpg: " show >show.commit &&
> - grep "gpg: " show >show.gpg &&
> + grep -v -e "gpg: " -e "Warning: " show >show.commit &&
> + grep -e "gpg: " -e "Warning: " show >show.gpg &&
> grep -v "^ " cat | grep -v "^gpgsig " >cat.commit &&
> test_cmp show.commit commit &&
> test_cmp show.gpg verify.2 &&
> ---
>
Michael J Gruber <git@drmicha.warpmail.net>