Re: [PATCH] t7510: do not fail when gpg warns about insecure memory
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Mar 9, 2015, 01:22 UTC
- Message-ID
- <20150309012214.GE4245@vauxhall.crustytoothpaste.net>
- In-Reply-To
- <CAPig+cTj_z0xpDmnSvb-S_wEbwzdcFsGwUkFdGWgcJhwZpfMFQ@mail.gmail.com>
On Sun, Mar 08, 2015 at 06:15:55PM -0400, Eric Sunshine wrote:
Show 14 quoted lines
>On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson ><sandals@crustytoothpaste.net> wrote: >> Perhaps this is better? >> >> Unfortunately when running the test, that message is found in the standard >> output of git show -s --show-signature, but in the standard error of git >> verify-commit -v causing the comparisons of both standard output and >> standard error to fail. > >That doesn't help me parse it any better. It's the "but" without a >corresponding "not" which seems to be throwing me off. Typically, one >would write "this but not that" or "not this but that". I can't tell >if there is a "not" missing or if the "but" is supposed to be an "and" >or if something else was intended.
The intended meaning is "and" with the additional sense of contrast. The sentence, if read with verbal emphasis, is, "…is found in the standard *output* of git show -s --signature, but in the standard *error* of git verify-commit -v", thus demonstrating why the test fails: the pairs of output files don't match up.
Maybe you can suggest a less confusing wording.
-- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187