Re: [PATCH 1/2] MinGW: fix compile error due to missing ELOOP
- From
Karsten Blees <karsten.blees@gmail.com>
- Date
- Jul 15, 2014, 23:57 UTC
- Message-ID
- <53C5BFF2.30001@gmail.com>
- In-Reply-To
- <20140715234257.GM12427@google.com>
Am 16.07.2014 01:42, schrieb Jonathan Nieder:
Show 18 quoted lines
> Karsten Blees wrote: > >> MinGW and MSVC before 2010 don't define ELOOP, use EMLINK (aka "Too many >> links") instead. > [...] >> +#ifndef ELOOP >> +#define ELOOP EMLINK >> +#endif > > This could use > > #define ELOOP WSAELOOP > > as an alternative. But it shouldn't matter since git doesn't look for > EMLINK anywhere (EMLINK = 31, WSAELOOP = wsabaseerr+62 = 10062). > > Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> >
It matters when we report the error to the user (i.e. via die_errno):
strerror(EMLINK) -> "Too many links" strerror(10062) -> "Unknown error"
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.