git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Topic sk/mingw-unicode-spawn-args breaks tests

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jul 11, 2014, 19:49 UTC
Message-ID
<53C03FBB.1080807@gmail.com>
In-Reply-To
<53BEF21E.9090007@kdbg.org>
Am 10.07.2014 22:05, schrieb Johannes Sixt:
Show 19 quoted lines
> It looks like I totally missed the topic sk/mingw-unicode-spawn-args.
> Now it's in master, and it breaks lots of test cases for me:
> 
> t0050-filesystem
> t0110-urlmatch-normalization
> t4014-format-patch
> t4041-diff-submodule-option
> t4120-apply-popt
> t4201-shortlog
> t4205-log-pretty-formats
> t4209-log-pickaxe
> t4210-log-i18n
> (I killed the test run here)
> 
> Am I doing something wrong? Does the topic depend on a particular
> version of MSYS (or DLL)?
> 
> -- Hannes
> 
After commenting out fchmod in config.c, I get similar results.

At first glance, t0050 seems to fail because the unicode file name patches are still missing.

t4041 tries to pass ISO-8859-1 encoded bytes on the command line, which simply doesn't work on Windows (all OS APIs 'talk' UTF-16). We have a fix for this in the msysgit fork [1] (but unfortunately in another branch, so Stepan couldn't know the patch is related).

I suspect the other failures also fall in these two categories.
[1] https://github.com/msysgit/git/commit/ef4a733c
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Johannes SixtNext: Stepan Kasal
Message 2 of 46 in “Topic sk/mingw-unicode-spawn-args breaks tests”
  1. Johannes SixtJul 10, 2014
  2. Karsten BleesJul 11, 2014
  3. Stepan KasalJul 12, 2014
  4. Johannes SchindelinJul 15, 2014
  5. 0/3 fix test suite with mingw-unicode patchesStepan Kasal, Jul 15, 2014
  6. 1/3 Win32: Unicode file name support (except dirent)Stepan Kasal, Jul 15, 2014
  7. 2/3 Win32: Unicode file name support (dirent)Stepan Kasal, Jul 15, 2014
  8. 3/3 tests: do not pass iso8859-1 encoded parameterStepan Kasal, Jul 15, 2014
  9. Stepan KasalJul 15, 2014
  10. Junio C HamanoJul 15, 2014
  11. Karsten BleesJul 15, 2014
  12. 1/2 MinGW: fix compile error due to missing ELOOPKarsten Blees, Jul 15, 2014
  13. Jonathan NiederJul 15, 2014
  14. Karsten BleesJul 15, 2014
  15. Junio C HamanoJul 16, 2014
  16. 2/2 config: use chmod() instead of fchmod()Karsten Blees, Jul 15, 2014
  17. Johannes SixtJul 16, 2014
  18. Karsten BleesJul 16, 2014
  19. Junio C HamanoJul 16, 2014
  20. Karsten BleesJul 17, 2014
  21. Stepan KasalJul 16, 2014
  22. Thomas BraunJul 16, 2014
  23. 0/6 mingw test fixesStepan Kasal, Jul 17, 2014
  24. 1/6 MinGW: Skip test redirecting to fd 4Stepan Kasal, Jul 17, 2014
  25. Junio C HamanoJul 17, 2014
  26. Johannes SchindelinJul 17, 2014
  27. Karsten BleesJul 17, 2014
  28. Junio C HamanoJul 17, 2014
  29. 2/6 Disable t0110's high-bit test on WindowsStepan Kasal, Jul 17, 2014
  30. Karsten BleesJul 17, 2014
  31. Junio C HamanoJul 18, 2014
  32. t0110/MinGW: skip tests that pass arbitrary bytes on the command lineKarsten Blees, Jul 19, 2014
  33. Junio C HamanoJul 21, 2014
  34. 3/6 MinGW: disable legacy encoding testsStepan Kasal, Jul 17, 2014
  35. 4/6 t4210: skip command-line encoding tests on mingwStepan Kasal, Jul 17, 2014
  36. Erik Faye-LundJul 18, 2014
  37. Junio C HamanoJul 21, 2014
  38. Johannes SchindelinJul 21, 2014
  39. Johannes SixtJul 21, 2014
  40. Junio C HamanoJul 21, 2014
  41. Junio C HamanoJul 21, 2014
  42. Junio C HamanoJul 21, 2014
  43. 2/2 test prerequisites: enumerate with commasJunio C Hamano, Jul 21, 2014
  44. 5/6 t9902: mingw-specific fix for gitfile link filesStepan Kasal, Jul 17, 2014
  45. Junio C HamanoJul 17, 2014
  46. 6/6 t800[12]: work around MSys limitationStepan Kasal, Jul 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.