Re: [PATCH 0/3] fix test suite with mingw-unicode patches

From: Stepan Kasal <kasal@ucw.cz>
Date: Jul 16, 2014, 09:29 UTC
Message-ID: <20140716092959.GA378@ucw.cz>
In-Reply-To: <53C5B0A1.4060502@gmail.com>

Hello Karsten,

thanks for your analysis. Most of the patches you refer to are simply switching off tests for MINGW; let me comment on the remaining ones:

Show 5 quoted lines

> * t0110-urlmatch-normalization: 1
> 
> Passing binary data on the command line...would have to
> teach test-urlmatch-normalization.c to read from stdin or file.
> https://github.com/msysgit/git/commit/be0d6dee

Indeed, that would be better solution. For now, I'm going to submit the switch-off patch you mention.

> * t4036-format-patch-signer-mime: 1
> 
> Passing non-ASCII by environment variable, will be fixed by Unicode
> environment support.

Will submit that patch series soon.

> * t7001-mv: 6
> cp -P fails in MinGW - perhaps use the long option forms (--no-dereference)?

"cp -P" fails with our 2001-edition of cp, so msysgit had to revert: https://github.com/msysgit/git/commit/6d3e23d4

But I was ashamed to mention that upstream; and I hope mingwGitDevEnv is going to solve that.

> * t8001-annotate/t8002-blame: 5
> 
> Msys.dll thinks '-L/regex/' is an absolute path and expands to '-LC:/msysgit/regex/'.
> https://github.com/msysgit/git/commit/2d52168a

Nice!  But I'm afraid the patch cannot be submitted upstream as it is.

I think the hack could be automated by processing options "-L*" this way:
    sed 'sX\(^-L\|,\)\^\?/X&\\;*Xg'
Then it would become only few lines at the top of the script, executed
on mingw only.
I hope to submit the patch in this form soon.

Have a nice day,
	Stepan

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.