git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [ANNOUNCE] Git v2.0.0

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 28, 2014, 23:17 UTC
Message-ID
<53866e8562b7a_12a7a052f87a@nysa.notmuch>
In-Reply-To
<xmqqr43dbkni.fsf@gitster.dls.corp.google.com>

This is the last mail I sent to you, because you ignore them anyway, and remove them from the mailing list.

I'm am cc'ing the git-fc mailing list so there's a public track record of this, so you can't claim it didn't happen.

Junio C Hamano wrote:
>  * The "remote-hg/bzr" remote-helper interfaces (used to be in
>    contrib/) are no more.  They are now maintained separately as
>    third-party plug-ins in their own repositories.

This is a lie. You are saying they don't exist any more, but they do exist, they "graduated" according to your same words.

Also, in mail [1] Jeff said:
  But that being said, this is Felipe's code. While we have a legal
  right to distribute it in v2.0, if he would really prefer it out for
  v2.0, I would respect that.

To which you agreed, however, after you fucked up v2.0 and removed an important patch, I said I changed my wish that I didn't want to disturb v2.0 in mail [2], a mail you conveniently removed from the tracked record.

In mail [3] you acknowledged my wish, and you said you were going to put stubs for v2.0, and you didn't. You also conveniently removed this mail from the archives.

Your rhetoric to make it appear as if the code is gone, your repeated failures to accomplish my wish, even you said you would, and your deliberate removal of the relevant discussion gives me no choice.

I threat all this as deliberate acts of aggression, and I will respond as I said I would, and bring as much public attention to what you are doing as possible.

[1] 20140516084126.GB21468@sigill.intra.peff.net [2] 537bbd6c1daf_a6f166b308b0@nysa.notmuch [3] xmqqlhtwrufq.fsf@gitster.dls.corp.google.com

For reference, here's the full content of mail [2]:
From: Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH] remote-helpers: point at their upstream repositories
To: Junio C Hamano <gitster@pobox.com>,  Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>,  git@vger.kernel.org
Date: Tue, 20 May 2014 15:39:08 -0500
--- text/plain ---
Junio C Hamano wrote:
Show 48 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > Junio C Hamano wrote:
> >
> >>   2. add warning that is given every time the scripts are run and
> >>      give the same instruction as in README.
> >> 
> >>   3. (optional) cripple the script to make them always fail after
> >>      showing the same warning as above.
> >
> > This is what I want, and I already sent the patches for; the scripts
> > will be stubs. At this point you would have effectively removed the
> > code, which what I want.
> >  
> >>   4. Keep README and retire everything else.
> >
> > After you've removed the code, I don't care what you do, but I'd say you
> > should remove the stubs after a long period of time.
> 
> Let's try this in a different way, as I sense there is a
> misunderstanding somewhere about your "wish".
> 
> >> "that" does not refer to "remove them at v2.0 (unconditional)".  It
> >> refers to "If Felipe really wants for the removal for v2.0, I would
> >> respect that".  And I saw you said you did not want to disrupt v2.0.
> >> 
> >> If the options I listed all meant removal at v2.0, then I would
> >> understand your complaints, but that is not the case, so I am not
> >> sure what to make of that.
> >
> > It is a weird choice of semantics then. You said you would "respect" my
> > wish, but your proposals did not "follow" my wish.
> 
> I understand you do not want to disrupt v2.0.  My assumption of that
> "not disrupting v2.0" has been "there still are git-remote-{hg,bzr}
> that work just like what they had in v1.9.x, perhaps with some
> enhancements and regressions you added in the meantime", and I
> understood Peff's comment "If Felipe wants the removal" to mean that
> kind of "disruption", i.e. "there is no git-remote-{hg,bzr} that
> work.", which would be either step 3 or 4.
> 
> But your "After you've removed the code" comment above makes me
> wonder that perhaps your definition of "not disrupting" was
> different from ours (which is not good or bad, just different) and
> you consider that step 3. is "removal but not distupting v2.0"?
> 
> If that is what you want in v2.0, then please say so, and I already
> said I am fine with that.

No, I already said I do not want the code removed from v2.0, that's why I sent patches that simply added a warning, and I specifically said those were for 2.0.

However, after seeing this commit:
10e1fee (Revert "Merge branch 'fc/transport-helper-sync-error-fix'")
Which is:
 1) Inaccurate
 2) A lie (*you* broke 2.0, not me)
 3) A disservice to users

I therefore change my wish for you to remove all the remote helpers code and a replace them with stubs (the patches I originally sent for post-2.0).

It was a mistake from me to believe you would do the sensible thing for 2.0.

So to make it clear, I now request that you do:
 1) Remove all the code.
    Since my patches were removed from the list, here's an updated patch
    that applies on top of 'master'
    https://github.com/felipec/git/commits/up/remote/remove
 2) Reapply d508e4a (Merge branch 'fc/transport-helper-sync-error-fix')
    Since the code in question is no longer part of v2.0, a "possible
    regression" that you aren't even sure of cannot be the rationale to
    revert this code.
    Your commit 10e1fee (Revert "Merge branch
    'fc/transport-helper-sync-error-fix'") actively hurts the
    out-of-tree tools, so I'll consider a failure to re-revert a hostile
    action.
 3) Update the release notes to mention these tools have been removed
  Additionally, you might want to:
 4) Re-add the following release note:
    * "git push" via transport-helper interface (e.g. remote-hg) has
      been updated to allow forced ref updates in a way similar to the
      natively supported transports
    I don't know why you removed it in the first place. Clearly you pay
    no attention at all to these interfaces.
I expect you to do at the very least 1) and 2).
-- 
Felipe Contreras
Previous: Junio C HamanoNext: Felipe Contreras
Message 3 of 15 in “[ANNOUNCE] Git v2.0.0”
  1. Junio C HamanoMay 28, 2014
  2. Junio C HamanoMay 28, 2014
  3. Felipe ContrerasMay 28, 2014
  4. Felipe ContrerasMay 28, 2014
  5. Jeff KingMay 29, 2014
  6. David KastrupMay 29, 2014
  7. Jeff KingMay 29, 2014
  8. Felipe ContrerasMay 30, 2014
  9. David KastrupMay 31, 2014
  10. Jeff KingJun 2, 2014
  11. Felipe ContrerasJun 2, 2014
  12. David KastrupJun 2, 2014
  13. NeilBrownJun 3, 2014
  14. Linus TorvaldsJun 3, 2014
  15. NeilBrownJun 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.