git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [ANNOUNCE] Git v2.0.0

From
NeilBrown <neilb@suse.de>
Date
Jun 3, 2014, 02:08 UTC
Message-ID
<20140603120832.7235c706@notabene.brown>
In-Reply-To
<xmqqr43dbkni.fsf@gitster.dls.corp.google.com>
On Wed, 28 May 2014 15:31:13 -0700 Junio C Hamano <gitster@pobox.com> wrote:
> The latest feature release Git v2.0.0 is now available at the
> usual places.
> 
> "git request-pull" lost a few "heuristics" that often led to mistakes.
> 
I've installed git 2.0.0 and now when I
  git request-pull master git://neil.brown.name/md

after tagging the current commit as "md/3.15-fixes" and pushing out the tag, I get

warn: No match for commit 2ac295a544dcae9299cba13ce250419117ae7fd1 found at git://neil.brown.name/md warn: Are you sure you pushed 'HEAD' there?

Yet 
   git ls-remote git://neil.brown.name/md | grep 2ac29
shows
2ac295a544dcae9299cba13ce250419117ae7fd1	refs/tags/md/3.15-fixes^{}
Which seems clear and unambiguous.

Does this mean that the 'end' arg to 'git request-pull' is no longer optional (i.e. the man page is wrong), or that too many heuristics were removed?

.... Looking through the change log a bit, it seems that if the 'end' arg is omitted, then the current 'branch' name is used and must match the same name at the git URL. Could it also check the current 'tag' name? As we are encouraged to used signed tags, this seems sensible. In fact, I would suggest checking for a tag first, and only considering the branch name if there is no tag on the current commit.

Thanks, NeilBrown

Previous: David KastrupNext: Linus Torvalds
Message 13 of 15 in “[ANNOUNCE] Git v2.0.0”
  1. Junio C HamanoMay 28, 2014
  2. Junio C HamanoMay 28, 2014
  3. Felipe ContrerasMay 28, 2014
  4. Felipe ContrerasMay 28, 2014
  5. Jeff KingMay 29, 2014
  6. David KastrupMay 29, 2014
  7. Jeff KingMay 29, 2014
  8. Felipe ContrerasMay 30, 2014
  9. David KastrupMay 31, 2014
  10. Jeff KingJun 2, 2014
  11. Felipe ContrerasJun 2, 2014
  12. David KastrupJun 2, 2014
  13. NeilBrownJun 3, 2014
  14. Linus TorvaldsJun 3, 2014
  15. NeilBrownJun 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.