Re: [PATCH v3 2/5] commit test: Change $PWD to $(pwd)

From: Johannes Sixt <j.sixt@viscovery.net>
Date: May 27, 2014, 05:46 UTC
Message-ID: <538426D3.8090107@viscovery.net>
In-Reply-To: <1401130586-93105-3-git-send-email-caleb@calebthompson.io>

Am 5/26/2014 20:56, schrieb Caleb Thompson:

Show 18 quoted lines

> Signed-off-by: Caleb Thompson <caleb@calebthompson.io>
> ---
>  t/t7507-commit-verbose.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> index 6d778ed..3b06d73 100755
> --- a/t/t7507-commit-verbose.sh
> +++ b/t/t7507-commit-verbose.sh
> @@ -8,7 +8,7 @@ cat >check-for-diff <<EOF
>  exec grep '^diff --git' "\$1"
>  EOF
>  chmod +x check-for-diff
> -test_set_editor "$PWD/check-for-diff"
> +test_set_editor "$(pwd)/check-for-diff"
>  
>  cat >message <<'EOF'
>  subject

Why? I see no benefit. Both $PWD and $(pwd) work fine everywhere, including Windows, and the former is faster, particularly on Windows.

-- Hannes