git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 5/5] commit: support commit.verbose and --no-verbose

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
May 26, 2014, 21:00 UTC
Message-ID
<20140526210035.GB11888@hudson.localdomain>
In-Reply-To
<CA+g4mq8iGNVm-2Uj8j2bJLDazaTS_U76BO9-jeS9Aw4RZnki5A@mail.gmail.com>
On Mon, May 26, 2014 at 03:39:55PM -0500, Caleb Thompson wrote:
> The editors, `check-for-diff` and `check-for-no-diffs`, are grepping for
> the output and lack thereof, respectively.
...
Show 5 quoted lines
> >
> > It appears that these tests still aren't checking to see if the
> > "verbose" output appears in the commit message.
> >
> >

OK, got it. The editor, set by test_set_editor, is run as part of the commit. Thanks for explaining that.

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
Previous: Caleb Thompson
Message 25 of 25 in “commit: support commit.verbose and --no-verbose”
  1. commit: support commit.verbose and --no-verboseCaleb Thompson, May 25, 2014
  2. Jeremiah MahlerMay 25, 2014
  3. Jeremiah MahlerMay 25, 2014
  4. Duy NguyenMay 25, 2014
  5. Eric SunshineMay 25, 2014
  6. 0/5 commit: support commit.verbose and --no-verboseCaleb Thompson, May 26, 2014
  7. 1/5 commit test: Use test_config instead of git-configCaleb Thompson, May 26, 2014
  8. 2/5 commit test: Change $PWD to $(pwd)Caleb Thompson, May 26, 2014
  9. Johannes SixtMay 27, 2014
  10. Eric SunshineMay 27, 2014
  11. Jeremiah MahlerMay 27, 2014
  12. Johannes SixtMay 27, 2014
  13. David KastrupMay 27, 2014
  14. 3/5 commit test: Use write_scriptCaleb Thompson, May 26, 2014
  15. Eric SunshineMay 27, 2014
  16. Junio C HamanoMay 27, 2014
  17. 4/5 commit test: test_set_editor in each testCaleb Thompson, May 26, 2014
  18. Eric SunshineMay 27, 2014
  19. 5/5 commit: support commit.verbose and --no-verboseCaleb Thompson, May 26, 2014
  20. Jeremiah MahlerMay 26, 2014
  21. Caleb ThompsonMay 26, 2014
  22. Jeremiah MahlerMay 26, 2014
  23. Jeremiah MahlerMay 26, 2014
  24. Caleb ThompsonMay 26, 2014
  25. Jeremiah MahlerMay 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.