Re: [PATCH v3 5/5] commit: support commit.verbose and --no-verbose
- From
Caleb Thompson <cjaysson@gmail.com>
- Date
- May 26, 2014, 20:47 UTC
- Message-ID
- <20140526204714.GA96869@sirius.att.net>
- In-Reply-To
- <20140526203304.GA11888@hudson.localdomain>
The editors, `check-for-diff` and `check-for-no-diffs`, are grepping for the output and lack thereof, respectively.
On Mon, May 26, 2014 at 01:33:04PM -0700, Jeremiah Mahler wrote:
Show 47 quoted lines
> j > On Mon, May 26, 2014 at 01:56:26PM -0500, Caleb Thompson wrote: > > Add a new configuration variable commit.verbose to implicitly pass > > > ... > > +test_expect_success 'commit shows verbose diff with set commit.verbose=true' ' > > + echo morecontent >>file && > > + git add file && > > + test_config commit.verbose true && > > + test_set_editor "$(pwd)/check-for-diff" && > > + git commit --amend > > +' > > + > > +test_expect_success 'commit --verbose overrides verbose=false' ' > > + echo evenmorecontent >>file && > > + git add file && > > + test_config commit.verbose false && > > + test_set_editor "$(pwd)/check-for-diff" && > > + git commit --amend --verbose > > +' > > + > > +test_expect_success 'commit does not show verbose diff with commit.verbose=false' ' > > + echo evenmorecontent >>file && > > + git add file && > > + test_config commit.verbose false && > > + test_set_editor "$(pwd)/check-for-no-diff" && > > + git commit --amend > > +' > > + > > +test_expect_success 'commit --no-verbose overrides commit.verbose=true' ' > > + echo evenmorecontent >>file && > > + git add file && > > + test_config commit.verbose true && > > + test_set_editor "$(pwd)/check-for-no-diff" && > > + git commit --amend --no-verbose > > +' > > + > ... > > > > It appears that these tests still aren't checking to see if the > "verbose" output appears in the commit message. > > -- > Jeremiah Mahler > jmmahler@gmail.com > http://github.com/jmahler