Re: [PATCH 4/8] CodingGuidelines: give an example for control statements

From: Stefan Beller <stefanbeller@gmail.com>
Date: Apr 30, 2014, 21:54 UTC
Message-ID: <5361711F.1030208@gmail.com>
In-Reply-To: <1398894312-30763-5-git-send-email-gitster@pobox.com>

On 30.04.2014 23:45, Junio C Hamano wrote:

Show 14 quoted lines

> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Documentation/CodingGuidelines | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index 1e0c4cf..d72e912 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -97,6 +97,17 @@ For shell scripts specifically (not exhaustive):
>     "then" should be on the next line for if statements, and "do"
>     should be on the next line for "while" and "for".
>  
> +	(incorrect)

At the other patches you used #comments behind oneliners, not sure if that's also suitable here for consistency of the documentation.

Show 14 quoted lines

> +	if test -f hello; then
> +		do this
> +	fi
> +
> +	(correct)
> +	if test -f hello
> +	then
> +		do this
> +	fi
> +
>   - We prefer "test" over "[ ... ]".
>  
>   - We do not write the noiseword "function" in front of shell
>