Re: [RTC/PATCH] Add 'update-branch' hook

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 24, 2014, 18:08 UTC
Message-ID: <53595317c11b4_1f7b143d31089@nysa.notmuch>
In-Reply-To: <8538h24xdg.fsf@stephe-leake.org>

Stephen Leake wrote:

Show 12 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> >> >> I have a branch which should always be recompiled on update;
> >> >> post-update-branch would be a good place for that.
> >> >
> >> > And why would pre-update-branch not serve that purpose?
> >> 
> >> Because the code that needs to be compiled is not yet in the workspace
> >
> > And it won't be in 'post-update-branch' either.
> 
> Then you are using a very odd definition of "post update"

It's not. The branch was updated, not the workspace.

Show 9 quoted lines

> >  % git checkout master
> >  % git branch feature-a stable
> >  <- update-branch hook will be called here
> >
> > The hook will get 'feature-a' as the first argument, but the code in the
> > workspace would correspond to 'master'; the checked out branch (pre or post).
> 
> Then the hooks should be called 'pre-branch', 'post-branch'; there is no
> "update" involved.

Of course there is. A 'branch' hook would be triggered when you create a new branch (e.g. `git branch`), however, it should not be triggered when you update a branch (e.g. `git rebase`).

> The hook I need is actually "post-merge", since "merge" is the command that
> updates the workspace.

I'd say it's probably 'post-checkout'.

-- 
Felipe Contreras