Re: [RTC/PATCH] Add 'update-branch' hook

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 21, 2014, 21:15 UTC
Message-ID: <53558a663ea74_604be1f30c2c@nysa.notmuch>
In-Reply-To: <53558AD0.3010602@gmail.com>

Ilya Bobyr wrote:

Show 31 quoted lines

> On 4/20/2014 7:23 PM, Felipe Contreras wrote:
> > [...]
> >
> > diff --git a/t/t5408-update-branch-hook.sh b/t/t5408-update-branch-hook.sh
> > new file mode 100755
> > index 0000000..d921c0e
> > --- /dev/null
> > +++ b/t/t5408-update-branch-hook.sh
> > @@ -0,0 +1,39 @@
> > +#!/bin/sh
> > +
> > +test_description='Test the update-branch hook'
> > +
> > +. ./test-lib.sh
> > +
> > +setup () {
> > +	mkdir -p .git/hooks &&
> > +	cat > .git/hooks/update-branch <<-'EOF' &&
> > +	#!/bin/sh
> > +	echo $@ > .git/update-branch.args
> > +	EOF
> > +	chmod +x .git/hooks/update-branch &&
> > +	echo one > content &&
> > +	git add content &&
> > +	git commit -a -m one
> > +}
> > +
> > +setup
> 
> According to t/README `setup` should be inside an assertion just as any
> other test:

I have a bunch of 'setup' calls outside such assertions already in other test scripts. If you know how to put single quotes inside of single quotes in a shell script, please share that knowledge, otherwise the setup must be outside.

Of course we could do the extremely reduntant:

test_expect_success 'setup' '
  setup
'

-- 
Felipe Contreras