Re: [RTC/PATCH] Add 'update-branch' hook

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 22, 2014, 17:28 UTC
Message-ID: <5356a6ae93668_463e11ef310e6@nysa.notmuch>
In-Reply-To: <5356A25D.1050001@gmail.com>

Ilya Bobyr wrote:

Show 14 quoted lines

> On 4/22/2014 9:31 AM, Felipe Contreras wrote:
> > Stephen Leake wrote:
> >> Felipe Contreras <felipe.contreras@gmail.com> writes:
> >>> Yes, there a reason for the existance of those hooks. Now tell me why would
> >>> anybody use post-update-branch instead of pre-update-branch?
> >> 
> >> I have a branch which should always be recompiled on update;
> >> post-update-branch would be a good place for that.
> >> 
> > And why would pre-update-branch not serve that purpose?
> 
> "pre-" hook could be used, but if the hooks is not supposed to prevent
> the operation, it seems reasonable to put it in the "post-" hook should
> one be available.

If 'pre-update-branch' can be used, then you are pretty much agreeing to the fact that the 'post-udpate-branch' hook would be *useless*.

Such a script would work both as 'pre-update-branch' and 'post-update-branch', therefore a single 'update-branch' would serve.

So I ask again:

Tell me why would anybody need 'post-update-branch' instead of 'pre-update-branch'?

-- 
Felipe Contreras