git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-pack.c: mark a file-local function static

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Dec 13, 2013, 22:50 UTC
Message-ID
<52AB8F31.40107@ramsay1.demon.co.uk>
In-Reply-To
<CACsJy8DnVUc2xQGD4hr2tuFhaGj4kuc=63xxmmUwq1bkFtztOw@mail.gmail.com>
On 13/12/13 00:58, Duy Nguyen wrote:
Show 11 quoted lines
> On Fri, Dec 13, 2013 at 6:15 AM, Ramsay Jones
> <ramsay@ramsay1.demon.co.uk> wrote:
>> BTW, I have not been following these patches, but I noticed that the
>> 'remove_nonexistent_ours_in_pack()' function has no callers. (There are
>> two commented out callers - but they seem to have *always* been commented
>> out ;-) ). So, step 5 is no longer required? :-D
> 
> It's more of an optimization than a requirement, to avoid expensive
> calculation later. Uncommenting is possible but I need to pass the
> pack file name around a bit.
> 
Ah, OK.
(I should probably refrain from commenting on code I haven't read ... :-P )

ATB, Ramsay Jones

Previous: Duy Nguyen
Message 3 of 3 in “send-pack.c: mark a file-local function static”
  1. send-pack.c: mark a file-local function staticRamsay Jones, Dec 12, 2013
  2. Duy NguyenDec 13, 2013
  3. Ramsay JonesDec 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.