[PATCH] send-pack.c: mark a file-local function static
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Dec 12, 2013, 23:15 UTC
- Message-ID
- <52AA43AA.9030703@ramsay1.demon.co.uk>
Commit f2c681cf ("send-pack: support pushing from a shallow clone via http", 05-12-2013) adds the 'advertise_shallow_grafts_buf' function as an external symbol. This symbol does not require more than file visibility.
Noticed by sparse. ("'advertise_shallow_grafts_buf' was not declared. Should it be static?")
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> ---
Hi Duy,
If you need to re-roll the patches in your 'nd/shallow-clone' branch, could you please squash this into your patch. Thanks!
BTW, I have not been following these patches, but I noticed that the 'remove_nonexistent_ours_in_pack()' function has no callers. (There are two commented out callers - but they seem to have *always* been commented out ;-) ). So, step 5 is no longer required? :-D
ATB, Ramsay Jones
send-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/send-pack.c b/send-pack.c index 2a199cc..6129b0f 100644 --- a/send-pack.c +++ b/send-pack.c @@ -183,7 +183,7 @@ static int advertise_shallow_grafts_cb(const struct commit_graft *graft, void *c return 0; } -void advertise_shallow_grafts_buf(struct strbuf *sb) +static void advertise_shallow_grafts_buf(struct strbuf *sb) { if (!is_repository_shallow()) return;
-- 1.8.5