From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Fri, 13 Dec 2013 22:50:25 GMT
Subject: Re: [PATCH] send-pack.c: mark a file-local function static
Message-ID: <52AB8F31.40107@ramsay1.demon.co.uk>
In-Reply-To: <CACsJy8DnVUc2xQGD4hr2tuFhaGj4kuc=63xxmmUwq1bkFtztOw@mail.gmail.com>

On 13/12/13 00:58, Duy Nguyen wrote:
> On Fri, Dec 13, 2013 at 6:15 AM, Ramsay Jones
> <ramsay@ramsay1.demon.co.uk> wrote:
>> BTW, I have not been following these patches, but I noticed that the
>> 'remove_nonexistent_ours_in_pack()' function has no callers. (There are
>> two commented out callers - but they seem to have *always* been commented
>> out ;-) ). So, step 5 is no longer required? :-D
> 
> It's more of an optimization than a requirement, to avoid expensive
> calculation later. Uncommenting is possible but I need to pass the
> pack file name around a bit.
> 

Ah, OK.

(I should probably refrain from commenting on code I haven't read ... :-P )

ATB,
Ramsay Jones