git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] branch: use $curr_branch_short more

From
René Scharfe <l.s.r@web.de>
Date
Sep 8, 2013, 15:21 UTC
Message-ID
<522C95F3.5030308@web.de>
In-Reply-To
<CAMP44s39X2SsZC7f6=j=CX+9wky7YpiJUz3itCiqeLScD0TbNA@mail.gmail.com>
Am 31.08.2013 19:20, schrieb Felipe Contreras:
Show 9 quoted lines
> A summary should contain as much information that would allow me to
> skip the commit message as possible.
>
> If I can't tell from the summary if I can safely skip the commit
> message, the summary is not doing a good job.
>
> "trivial simplification" explains the "what", and the "why" at the
> same time, and allows most people to skip the commit message, thus is
> a good summary.

No patch should be skipped on the mailing list. As you wrote, trivial patches can still be wrong.

When going through the history I can see that quickly recognizing insubstantial changes is useful, but if I see a summary twice then in my mind forms a big question mark -- why did the same thing had to be done yet again?

As an example, both 0d12e59f (pull: replace unnecessary sed invocation) and bc2bbc45 (pull, rebase: simplify to use die()) could arguably have had the summary "trivial simplification", but I'm glad the author went with something a bit more specific.

I agree that some kind of tagging with keywords like "trivial", "typo" and so on can be helpful, though.

> Again, triviality and correctness are two separate different things.
> The patch is trivial even if you can't judge it's correctness.
Well, in terms of impact I agree.
> To me, what you are describing is an obvious patch, not a trivial one.
> An obvious patch is so obvious that you can judge it's correctness
> easily by looking at the diff, a trivial one is of little importance.

That's one definition; I think I had the mathematical notion in mind that calls proofs trivial which are immediately evident.

René
Previous: Felipe ContrerasNext: Felipe Contreras
Message 21 of 26 in “Trivial cleanups and fixes”
  1. 0/6 Trivial cleanups and fixesFelipe Contreras, Aug 30, 2013
  2. 1/6 reset: trivial refactoringFelipe Contreras, Aug 30, 2013
  3. Junio C HamanoAug 31, 2013
  4. 2/6 branch: trivial style fixFelipe Contreras, Aug 30, 2013
  5. Junio C HamanoAug 31, 2013
  6. 3/6 rebase: trivial style fixesFelipe Contreras, Aug 30, 2013
  7. Junio C HamanoAug 31, 2013
  8. 4/6 reset: trivial style cleanupFelipe Contreras, Aug 30, 2013
  9. Junio C HamanoAug 31, 2013
  10. 5/6 add: trivial style cleanupFelipe Contreras, Aug 30, 2013
  11. Junio C HamanoAug 31, 2013
  12. 6/6 pull: trivial cleanupFelipe Contreras, Aug 30, 2013
  13. Junio C HamanoAug 31, 2013
  14. Felipe ContrerasAug 31, 2013
  15. branch: use $curr_branch_short moreRené Scharfe, Aug 31, 2013
  16. Felipe ContrerasAug 31, 2013
  17. René ScharfeAug 31, 2013
  18. Felipe ContrerasAug 31, 2013
  19. René ScharfeAug 31, 2013
  20. Felipe ContrerasAug 31, 2013
  21. René ScharfeSep 8, 2013
  22. Felipe ContrerasSep 8, 2013
  23. René ScharfeSep 15, 2013
  24. Felipe ContrerasSep 15, 2013
  25. Junio C HamanoSep 3, 2013
  26. pull: use $curr_branch_short moreRené Scharfe, Sep 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.