git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] pull: trivial cleanup

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Aug 30, 2013, 21:56 UTC
Message-ID
<1377899810-1818-7-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1377899810-1818-1-git-send-email-felipe.contreras@gmail.com>
There's no need to remove 'refs/heads/' yet again.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 git-pull.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/git-pull.sh b/git-pull.sh
index f0df41c..3bdcbfd 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -166,7 +166,6 @@ error_on_no_merge_candidates () {
 		op_prep=with
 	fi
 
-	curr_branch=${curr_branch#refs/heads/}
 	upstream=$(git config "branch.$curr_branch.merge")
 	remote=$(git config "branch.$curr_branch.remote")
 
@@ -183,7 +182,7 @@ error_on_no_merge_candidates () {
 		echo "You asked to pull from the remote '$1', but did not specify"
 		echo "a branch. Because this is not the default configured remote"
 		echo "for your current branch, you must specify a branch on the command line."
-	elif [ -z "$curr_branch" -o -z "$upstream" ]; then
+	elif [ -z "$curr_branch_short" -o -z "$upstream" ]; then
 		. git-parse-remote
 		error_on_missing_default_upstream "pull" $op_type $op_prep \
 			"git pull <remote> <branch>"
-- 
1.8.4-fc
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 26 in “Trivial cleanups and fixes”
  1. 0/6 Trivial cleanups and fixesFelipe Contreras, Aug 30, 2013
  2. 1/6 reset: trivial refactoringFelipe Contreras, Aug 30, 2013
  3. Junio C HamanoAug 31, 2013
  4. 2/6 branch: trivial style fixFelipe Contreras, Aug 30, 2013
  5. Junio C HamanoAug 31, 2013
  6. 3/6 rebase: trivial style fixesFelipe Contreras, Aug 30, 2013
  7. Junio C HamanoAug 31, 2013
  8. 4/6 reset: trivial style cleanupFelipe Contreras, Aug 30, 2013
  9. Junio C HamanoAug 31, 2013
  10. 5/6 add: trivial style cleanupFelipe Contreras, Aug 30, 2013
  11. Junio C HamanoAug 31, 2013
  12. 6/6 pull: trivial cleanupFelipe Contreras, Aug 30, 2013
  13. Junio C HamanoAug 31, 2013
  14. Felipe ContrerasAug 31, 2013
  15. branch: use $curr_branch_short moreRené Scharfe, Aug 31, 2013
  16. Felipe ContrerasAug 31, 2013
  17. René ScharfeAug 31, 2013
  18. Felipe ContrerasAug 31, 2013
  19. René ScharfeAug 31, 2013
  20. Felipe ContrerasAug 31, 2013
  21. René ScharfeSep 8, 2013
  22. Felipe ContrerasSep 8, 2013
  23. René ScharfeSep 15, 2013
  24. Felipe ContrerasSep 15, 2013
  25. Junio C HamanoSep 3, 2013
  26. pull: use $curr_branch_short moreRené Scharfe, Sep 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.