git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] branch: use $curr_branch_short more

From
René Scharfe <l.s.r@web.de>
Date
Aug 31, 2013, 09:11 UTC
Message-ID
<5221B324.7020908@web.de>
In-Reply-To
<CAMP44s1qyF70eSCM4L1Yr=U02AwFZ0TNqiDvag8Qdzzi9GS1Mw@mail.gmail.com>
Am 31.08.2013 10:22, schrieb Felipe Contreras:
>> Subject: branch: use $curr_branch_short more
>
> Why? I don't think that summary explains the reason for being for this
> patch, also, it starts with branch: instead of pull:
You're right about "branch" vs. "pull".  I'll better go back to bed. ~_~
> Subject: pull: trivial simplification
>
> With that summary, people would have an easier time figuring out if
> they need to read more about the patch or not.

"trivial simplification" is too generic; we could have lots of them. A summary should describe the change. Its low complexity can be derived from it -- using an existing variable a bit more is not very exciting.

But I wouldn't call that patch trivial because its correctness depends on code outside of its shown context.

The reason for the patch isn't mentioned explicitly. Perhaps it should be. I felt that using something that's already there instead of recreating it is motivation alone.

René
Previous: Felipe ContrerasNext: Felipe Contreras
Message 17 of 26 in “Trivial cleanups and fixes”
  1. 0/6 Trivial cleanups and fixesFelipe Contreras, Aug 30, 2013
  2. 1/6 reset: trivial refactoringFelipe Contreras, Aug 30, 2013
  3. Junio C HamanoAug 31, 2013
  4. 2/6 branch: trivial style fixFelipe Contreras, Aug 30, 2013
  5. Junio C HamanoAug 31, 2013
  6. 3/6 rebase: trivial style fixesFelipe Contreras, Aug 30, 2013
  7. Junio C HamanoAug 31, 2013
  8. 4/6 reset: trivial style cleanupFelipe Contreras, Aug 30, 2013
  9. Junio C HamanoAug 31, 2013
  10. 5/6 add: trivial style cleanupFelipe Contreras, Aug 30, 2013
  11. Junio C HamanoAug 31, 2013
  12. 6/6 pull: trivial cleanupFelipe Contreras, Aug 30, 2013
  13. Junio C HamanoAug 31, 2013
  14. Felipe ContrerasAug 31, 2013
  15. branch: use $curr_branch_short moreRené Scharfe, Aug 31, 2013
  16. Felipe ContrerasAug 31, 2013
  17. René ScharfeAug 31, 2013
  18. Felipe ContrerasAug 31, 2013
  19. René ScharfeAug 31, 2013
  20. Felipe ContrerasAug 31, 2013
  21. René ScharfeSep 8, 2013
  22. Felipe ContrerasSep 8, 2013
  23. René ScharfeSep 15, 2013
  24. Felipe ContrerasSep 15, 2013
  25. Junio C HamanoSep 3, 2013
  26. pull: use $curr_branch_short moreRené Scharfe, Sep 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.