Re: [PATCH 1/2] read-cache.c: don't guard calls to progress.c API

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 7, 2021, 15:28 UTC
Message-ID: <51e00403-dcab-c57f-b77a-de01a61a60eb@gmail.com>
In-Reply-To: <patch-1.2-1680109655-20210607T144206Z-avarab@gmail.com>

On 6/7/2021 10:43 AM, Ævar Arnfjörð Bjarmason wrote:

> Don't guard the calls to the progress.c API with "if (progress)". The
> API itself will check this. This doesn't change any behavior, but
> makes this code consistent with the rest of the codebase.

Since stop_progress() closes a trace2 region, this actually does make a change in behavior, I think. In a good way.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.