From: Derrick Stolee Date: Mon, 07 Jun 2021 15:28:03 GMT Subject: Re: [PATCH 1/2] read-cache.c: don't guard calls to progress.c API Message-ID: <51e00403-dcab-c57f-b77a-de01a61a60eb@gmail.com> In-Reply-To: On 6/7/2021 10:43 AM, Ævar Arnfjörð Bjarmason wrote: > Don't guard the calls to the progress.c API with "if (progress)". The > API itself will check this. This doesn't change any behavior, but > makes this code consistent with the rest of the codebase. Since stop_progress() closes a trace2 region, this actually does make a change in behavior, I think. In a good way. Thanks, -Stolee