Re: [PATCH v3 3/5] submodule.c: add .gitmodules staging helper functions
- From
Jens Lehmann <jens.lehmann@web.de>
- Date
- Jul 30, 2013, 23:13 UTC
- Message-ID
- <51F84881.9040204@web.de>
- In-Reply-To
- <7vsiyvvidl.fsf@alter.siamese.dyndns.org>
Am 30.07.2013 23:37, schrieb Junio C Hamano:
Show 15 quoted lines
> Jens Lehmann <Jens.Lehmann@web.de> writes: > >> +int is_staging_gitmodules_ok() > > Will tweak this to: > > int is_staging_gitmodules_ok(void) > > and fix this as well: > >> +int is_staging_gitmodules_ok(); >> +void stage_updated_gitmodules(void); > > > before queuing.
Thanks. As Frederik already noticed, this series is missing at least one strbuf_release(). Will fix both in v4.