From: Jens Lehmann Date: Tue, 30 Jul 2013 23:13:05 GMT Subject: Re: [PATCH v3 3/5] submodule.c: add .gitmodules staging helper functions Message-ID: <51F84881.9040204@web.de> In-Reply-To: <7vsiyvvidl.fsf@alter.siamese.dyndns.org> Am 30.07.2013 23:37, schrieb Junio C Hamano: > Jens Lehmann writes: > >> +int is_staging_gitmodules_ok() > > Will tweak this to: > > int is_staging_gitmodules_ok(void) > > and fix this as well: > >> +int is_staging_gitmodules_ok(); >> +void stage_updated_gitmodules(void); > > > before queuing. Thanks. As Frederik already noticed, this series is missing at least one strbuf_release(). Will fix both in v4.