git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Cygwin has trustable filemode

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Jul 20, 2013, 20:12 UTC
Message-ID
<51EAEF1B.6090300@ramsay1.demon.co.uk>
In-Reply-To
<51E982D0.5040505@gmail.com>
Mark Levedahl wrote:
Show 21 quoted lines
> On 07/19/2013 12:40 PM, Junio C Hamano wrote:
>> Thanks, will replace.
>>
>> What do we want to do with the compat/regex build-time switch?
>>
>> IIRC, this was only needed for 1.7 and not 1.5, and I also would
>> expect (without anything to back-up, so this is more a faith than
>> expectation) over time the "new library" would have a working regex
>> library.
>>
> 
> The situation is that Cygwin uses newlib rather than glibc, and does so 
> for licesnsing reasons (redhat sells licenses to developers allowing 
> closed source applications built using Cygwin). So, there must be a 
> compelling need to fix the library - git has a simple work around, so 
> isn't the case. Also, Cygwin has a perl regex library for those 
> demanding more complete / correct regex solution. So, I make no 
> prediction on when the newlib regex functions are fixed.
> 
> Related: Should we have separate settings for 1.5 and 1.7 for several 
> variables?
We already do.
>               Conflicts I see not reflected in config.mak.uname on pu:
>      trustable filemode   (1.7 has, 1.5 does not)
I see no need for any difference here. puzzled.
>      MMAP/Pread (1.7 pread is thread safe, 1.5 I dont think was, MMAP 
> utility is convolved in this)

pread() is now thread-safe? great! (It must have been a fairly recent change; last time I looked it was still not thread-safe on 1.7.)

>      regex - 1.7 is broken, per Ramsay 1.5 works

I don't see any reason not to use the compat/regex routines on both cygwin 1.5 and 1.7. However, I wouldn't object to restricting the use of the compat routines to cygwin 1.7 either!

> If you think its worth it, I'll create a patch series with the above and 
> justifications for the different settings that I know.

As far as I can see, only the pread() and maybe MMAP and regex setting need to change from the current setup.

ATB, Ramsay Jones

Previous: Jonathan NiederNext: Ramsay Jones
Message 14 of 19 in “Cygwin has trustable filemode”
  1. Cygwin has trustable filemodeMark Levedahl, Jul 14, 2013
  2. Ramsay JonesJul 16, 2013
  3. Mark LevedahlJul 16, 2013
  4. Cygwin has trustable filemodeMark Levedahl, Jul 19, 2013
  5. Junio C HamanoJul 19, 2013
  6. Mark LevedahlJul 19, 2013
  7. Junio C HamanoJul 19, 2013
  8. Mark LevedahlJul 19, 2013
  9. 1/4 Cygwin 1.7 has trustable filemodeMark Levedahl, Jul 19, 2013
  10. 2/4 Cygwin 1.7 needs compat/regexMark Levedahl, Jul 19, 2013
  11. 3/4 Cygwin 1.7 has thread-safe preadMark Levedahl, Jul 19, 2013
  12. 4/4 Cygwin 1.7 supports mmapMark Levedahl, Jul 19, 2013
  13. Jonathan NiederJul 19, 2013
  14. Ramsay JonesJul 20, 2013
  15. Ramsay JonesJul 20, 2013
  16. Junio C HamanoJul 21, 2013
  17. Mark LevedahlJul 22, 2013
  18. Junio C HamanoJul 22, 2013
  19. Mark LevedahlJul 22, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.