git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Cygwin has trustable filemode

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Jul 20, 2013, 19:52 UTC
Message-ID
<51EAEA76.9060502@ramsay1.demon.co.uk>
In-Reply-To
<1374245631-15955-1-git-send-email-mlevedahl@gmail.com>
Mark Levedahl wrote:
Show 22 quoted lines
> The supported Cygwin distribution on supported Windows versions provides
> complete support for POSIX filemodes, so enable this by default. git as
> distributed by the Cygwin project is configured this way.
> 
> This fixes one testsuite failure:
> t3300 test 17 (diff-index -M -p with mode change quotes funny filename)
> 
> Historical notes: Cygwin version 1.7 supports Windows-XP and newer, thus 
> dropped support for all OS variants that lack NTFS and/or the full win32 
> api, and since late 1.5 development, Cygwin maps POSIX modes to NTFS ACLs 
> by default.  Cygwin 1.5 supported OS variants that used FAT as the native 
> file system, and had optional methods for providing POSIX file modes on 
> top of FAT12/16 and NTFS, though not FAT32.  Also, support for POSIX modes 
> on top of FAT were dropped later in 1.5.  Thus, POSIX filemode support 
> could not be expected by default on a Cygwin 1.5 installation, but is 
> expected by default on a 1.7 installation.
> 
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> ---
> Junio - The above notes are more accurate than in my previous commit message,
> so if this commit survives into next/master, I would prefer this version as
> opposed to the one now on pu (da875762)

Again, I have to ask; should you not "revert" commit c869753e ("Force core.filemode to false on Cygwin.", 30-12-2006)? After this commit, there is no longer any user of the NO_TRUSTABLE_FILEMODE build variable, and no real prospect of anyone else wanting to use it.

ATB, Ramsay Jones

Previous: Ramsay JonesNext: Junio C Hamano
Message 15 of 19 in “Cygwin has trustable filemode”
  1. Cygwin has trustable filemodeMark Levedahl, Jul 14, 2013
  2. Ramsay JonesJul 16, 2013
  3. Mark LevedahlJul 16, 2013
  4. Cygwin has trustable filemodeMark Levedahl, Jul 19, 2013
  5. Junio C HamanoJul 19, 2013
  6. Mark LevedahlJul 19, 2013
  7. Junio C HamanoJul 19, 2013
  8. Mark LevedahlJul 19, 2013
  9. 1/4 Cygwin 1.7 has trustable filemodeMark Levedahl, Jul 19, 2013
  10. 2/4 Cygwin 1.7 needs compat/regexMark Levedahl, Jul 19, 2013
  11. 3/4 Cygwin 1.7 has thread-safe preadMark Levedahl, Jul 19, 2013
  12. 4/4 Cygwin 1.7 supports mmapMark Levedahl, Jul 19, 2013
  13. Jonathan NiederJul 19, 2013
  14. Ramsay JonesJul 20, 2013
  15. Ramsay JonesJul 20, 2013
  16. Junio C HamanoJul 21, 2013
  17. Mark LevedahlJul 22, 2013
  18. Junio C HamanoJul 22, 2013
  19. Mark LevedahlJul 22, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.