[PATCH] Cygwin has trustable filemode
- From
Mark Levedahl <mlevedahl@gmail.com>
- Date
- Jul 14, 2013, 16:13 UTC
- Message-ID
- <1373818390-14451-1-git-send-email-mlevedahl@gmail.com>
The supported Cygwin distribution on supported Windows versions provides complete support for POSIX filemodes, so enable this by default. git as distributed by the Cygwin project is configured this way.
This fixes one testsuite failure: t3300 test 17 (diff-index -M -p with mode change quotes funny filename)
Historical notes: Earlier versions of Cygwin (version 1.5 and prior) had various methods for supporting posix file modes on different file systems, often using extended attributes, and this support was optional. Such versions of Cygwin are not available on any public mirror and are not supported by the Cygwin project. The currently available Cygwin supports POSIX file modes without exception - this is not an optional configuration. The support does depend upon the underlying file system (neither Linux nor Cygwin can set an execute bit on a FAT file system as FAT has no such support), but as this is no different than Linux, the default should not treat Cygwin differently than Linux.
Users who desire the non-POSIX mode of operation must explicitly set core.filemode=False, accepting non-interoperability with Linux.
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> --- config.mak.uname | 1 - 1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname index 7ac541e..779d06a 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -163,7 +163,6 @@ ifeq ($(uname_O),Cygwin) NO_THREAD_SAFE_PREAD = YesPlease NEEDS_LIBICONV = YesPlease NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes - NO_TRUSTABLE_FILEMODE = UnfortunatelyYes NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease # There are conflicting reports about this. # On some boxes NO_MMAP is needed, and not so elsewhere.
-- 1.8.3.2.0.13