Re: [PATCH 2/2] git-svn: allow git-svn fetching to work using serf
- From
- David Rothenberger <daveroth@acm.org>
- Date
- Jul 7, 2013, 16:18 UTC
- Message-ID
- <51D994DC.9050500@acm.org>
- In-Reply-To
- <20130707133957.GA3648@lp-shahaf.local>
On 7/7/2013 6:39 AM, Daniel Shahaf wrote:
Show 22 quoted lines
> Kyle McKay wrote on Sat, Jul 06, 2013 at 19:46:40 -0700: >> On Jul 6, 2013, at 19:23, Jonathan Nieder wrote: >>> Kyle McKay wrote: >>> >>>> Unless bulk updates are disabled when using the serf access method >>>> (the only one available with svn 1.8) for https?: urls, >>>> apply_textdelta does indeed get called multiple times in a row >>>> without an intervening temp_release. >>> >>> You mean "Unless bulk updates are enabled" and "without an intervening >>> close_file", right? >> >> The problem seems to be skelta mode although it may just be the fact >> that ra_serf has multiple connections outstanding and since ra_neon only >> ever has one it can't happen over ra_neon. >> >> If the server disables bulk updates (SVNAllowBulkUpdates Off) all >> clients are forced to use skelta mode, even ra_neon clients. > > As Brane and I have pointed out, git-svn can instruct libsvn_* to use > bulk updates regardless of the server version, by setting > SVN_CONFIG_OPTION_HTTP_BULK_UPDATES (new in 1.8).
According to the table in the release notes [1], Skelta mode will be used if the 1.7 or 1.8 server sets SVNAllowBulkUpdates to Off, regardless of what the client sets in the configuration.
Is that not true?
[1] https://subversion.apache.org/docs/release-notes/1.8.html#neon-deleted
-- David Rothenberger ---- daveroth@acm.org