Re: [PATCH 2/2] git-svn: allow git-svn fetching to work using serf

From: Daniel Shahaf <danielsh@apache.org>
Date: Jul 7, 2013, 13:39 UTC
Message-ID: <20130707133957.GA3648@lp-shahaf.local>
In-Reply-To: <3871C226-16AE-4E25-8AD3-007EDAB0E25F@gmail.com>

Kyle McKay wrote on Sat, Jul 06, 2013 at 19:46:40 -0700:

Show 17 quoted lines

> On Jul 6, 2013, at 19:23, Jonathan Nieder wrote:
>> Kyle McKay wrote:
>>
>>> Unless bulk updates are disabled when using the serf access method
>>> (the only one available with svn 1.8) for https?: urls,
>>> apply_textdelta does indeed get called multiple times in a row
>>> without an intervening temp_release.
>>
>> You mean "Unless bulk updates are enabled" and "without an intervening
>> close_file", right?
>
> The problem seems to be skelta mode although it may just be the fact  
> that ra_serf has multiple connections outstanding and since ra_neon only 
> ever has one it can't happen over ra_neon.
>
> If the server disables bulk updates (SVNAllowBulkUpdates Off) all  
> clients are forced to use skelta mode, even ra_neon clients.

As Brane and I have pointed out, git-svn can instruct libsvn_* to use bulk updates regardless of the server version, by setting SVN_CONFIG_OPTION_HTTP_BULK_UPDATES (new in 1.8).

If you have questions about that, though, please address them to users@subversion.apache.org (the proper list for API usage questions), not to me personally.

Cheers,

Daniel