Re: [PATCH 2/2] git-svn: allow git-svn fetching to work using serf

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 7, 2013, 02:23 UTC
Message-ID: <20130707022332.GD4193@google.com>
In-Reply-To: <8CACBE8F-8672-43AB-882E-4ADA05B4D822@gmail.com>

Kyle McKay wrote:

> Unless bulk updates are disabled when using the serf access method
> (the only one available with svn 1.8) for https?: urls,
> apply_textdelta does indeed get called multiple times in a row
> without an intervening temp_release.

You mean "Unless bulk updates are enabled" and "without an intervening close_file", right?

Unlike the non-depth-first thing, that sounds basically broken --- what would be stopping subversion from calling the editor's close method when done with each file? I can't see much reason unless it is calling apply_textdelta multiple times in parallel --- is it doing that, and if so is git-svn able to cope with that?

This sounds like something that should be fixed in ra_serf.

But if the number of overlapping open text nodes is bounded by a low number, the workaround of using multiple temp files sounds ok as a way of dealing with unfixed versions of Subversion.

Jonathan