Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

From: Célestin Matte <celestin.matte@ensimag.fr>
Date: Jun 8, 2013, 20:08 UTC
Message-ID: <51B38F44.6080304@ensimag.fr>
In-Reply-To: <vpqmwr0v45b.fsf@anie.imag.fr>

Le 08/06/2013 20:38, Matthieu Moy a écrit :> This is right, but the code actually worked the way it was. I'm not

Show 5 quoted lines

> sure, but my understanding is that '\n' is the string "backslash
> followed by n", but interpreted as a regexp, it is a newline.
>
> The new code looks better than the old one, but the log message may be
> improved.

Is this better?

" In Perl, '\n' is not a newline, but instead the string composed of a backslash followed by an "n". To match newlines, one has to use the /\n/ regexp. As the output of "rev-list --first-parent" is line-oriented, what we want here is to match newlines, and not the "\n" string. "

-- 
Célestin Matte