git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 8, 2013, 18:38 UTC
Message-ID
<vpqmwr0v45b.fsf@anie.imag.fr>
In-Reply-To
<1370698510-11649-1-git-send-email-celestin.matte@ensimag.fr>
Célestin Matte <celestin.matte@ensimag.fr> writes:
> In Perl, '\n' is not a newline, but instead a literal backslash followed by an
> "n". As the output of "rev-list --first-parent" is line-oriented, what we want
> here is a newline.

This is right, but the code actually worked the way it was. I'm not sure, but my understanding is that '\n' is the string "backslash followed by n", but interpreted as a regexp, it is a newline.

The new code looks better than the old one, but the log message may be improved.

In any case, Acked-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Célestin MatteNext: Célestin Matte
Message 2 of 6 in “git-remote-mediawiki: Fix a bug in a regexp”
  1. git-remote-mediawiki: Fix a bug in a regexpCélestin Matte, Jun 8, 2013
  2. Matthieu MoyJun 8, 2013
  3. Célestin MatteJun 8, 2013
  4. Jeff KingJun 9, 2013
  5. Eric SunshineJun 9, 2013
  6. Eric SunshineJun 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.