git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Initialize variables with values

From
SSSven Strickroth <sven@cs-ware.de>
Date
May 9, 2013, 13:49 UTC
Message-ID
<518BA986.8060209@cs-ware.de>
In-Reply-To
<20130509132115.GA3375@elie>
Am 09.05.2013 15:21 schrieb Jonathan Nieder:
Show 20 quoted lines
> Sven Strickroth wrote:
> 
>> With MSVC initializing a variable with "int a=a" causes a warning about
>> using an uninitialized value.
> [...]
>> --- a/builtin/rev-list.c
>> +++ b/builtin/rev-list.c
>> @@ -338,7 +338,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
>>  		mark_edges_uninteresting(revs.commits, &revs, show_edge);
>>  
>>  	if (bisect_list) {
>> -		int reaches = reaches, all = all;
>> +		int reaches = 0, all = 0;
> 
> A correct way to spell this is
> 
> 		int reaches, all;
> 
> which, as a bonus, lets the compiler warn if they are used
> uninitialized.  Does that provoke warnings?
This seems to be ok.
-- 
Best regards,
 Sven Strickroth
 PGP key id F5A9D4C4 @ any key-server
Previous: Jonathan NiederNext: René Scharfe
Message 8 of 9 in “MSVC fixes”
  1. 0/3 MSVC fixesSven Strickroth, May 9, 2013
  2. 1/3 poll.h lies in the same folder, so use normal quotes for includeSven Strickroth, May 9, 2013
  3. Sven StrickrothMay 9, 2013
  4. 2/3 mingw.h: Define only if necessarySven Strickroth, May 9, 2013
  5. 3/3 Initialize variables with valuesSven Strickroth, May 9, 2013
  6. Krzysztof MazurMay 9, 2013
  7. Jonathan NiederMay 9, 2013
  8. Sven StrickrothMay 9, 2013
  9. René ScharfeMay 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.