From: Sven Strickroth <sven@cs-ware.de>
Date: Thu, 09 May 2013 13:49:58 GMT
Subject: Re: [PATCH 3/3] Initialize variables with values
Message-ID: <518BA986.8060209@cs-ware.de>
In-Reply-To: <20130509132115.GA3375@elie>

Am 09.05.2013 15:21 schrieb Jonathan Nieder:
> Sven Strickroth wrote:
> 
>> With MSVC initializing a variable with "int a=a" causes a warning about
>> using an uninitialized value.
> [...]
>> --- a/builtin/rev-list.c
>> +++ b/builtin/rev-list.c
>> @@ -338,7 +338,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
>>  		mark_edges_uninteresting(revs.commits, &revs, show_edge);
>>  
>>  	if (bisect_list) {
>> -		int reaches = reaches, all = all;
>> +		int reaches = 0, all = 0;
> 
> A correct way to spell this is
> 
> 		int reaches, all;
> 
> which, as a bonus, lets the compiler warn if they are used
> uninitialized.  Does that provoke warnings?

This seems to be ok.

-- 
Best regards,
 Sven Strickroth
 PGP key id F5A9D4C4 @ any key-server