Re: [PATCH 3/3] Initialize variables with values

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 9, 2013, 13:21 UTC
Message-ID: <20130509132115.GA3375@elie>
In-Reply-To: <518AF843.6040501@cs-ware.de>

Hi,

Sven Strickroth wrote:

> With MSVC initializing a variable with "int a=a" causes a warning about
> using an uninitialized value.

[...]

Show 8 quoted lines

> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -338,7 +338,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
>  		mark_edges_uninteresting(revs.commits, &revs, show_edge);
>  
>  	if (bisect_list) {
> -		int reaches = reaches, all = all;
> +		int reaches = 0, all = 0;

A correct way to spell this is

		int reaches, all;

which, as a bonus, lets the compiler warn if they are used uninitialized. Does that provoke warnings?

Thanks, Jonathan