Re: [PATCH 2/7] Modify fast-export testcase to check that we correctly omit tags of trees

From: Elijah Newren <newren@gmail.com>
Date: Jun 22, 2009, 13:12 UTC
Message-ID: <51419b2c0906220612l5ce0ee4fs6466bb13b001872f@mail.gmail.com>
In-Reply-To: <200906210817.51520.j6t@kdbg.org>

On Sun, Jun 21, 2009 at 12:17 AM, Johannes Sixt<j6t@kdbg.org> wrote:

Show 21 quoted lines

> On Samstag, 20. Juni 2009, newren@gmail.com wrote:
>> -test_expect_success 'tree_tag'        'git fast-export tree_tag'
>> +test_expect_success 'tree_tag'        '
>> +     mkdir result &&
>> +     cd result &&
>> +     git init &&
>> +     cd ..
>> +     git fast-export tree_tag | (cd result && git fast-import)
>> +'
>
> You should make this
>
> test_expect_success 'tree_tag' '
>        mkdir result &&
>        (cd result && git init) &&
>        git fast-export tree_tag > fe-stream &&
>        (cd result && git fast-import < fe-stream)
> '
>
> in order to (1) not remain in the wrong directory if git init fails, and (2)
> to catch failures in git fast-export.

Thanks for the tips; I've sent a new patch series with these changes (except that the second fe-stream needs a ../ in front of it), as well as the changes suggested by Stephen Boyd in the other email in this thread.

Elijah