git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] fast-export: Omit tags that tag trees

From
Jeff King <peff@peff.net>
Date
Jun 20, 2009, 17:31 UTC
Message-ID
<20090620173128.GE31022@coredump.intra.peff.net>
In-Reply-To
<1245472623-28103-2-git-send-email-newren@gmail.com>
On Fri, Jun 19, 2009 at 10:36:57PM -0600, newren@gmail.com wrote:
Show 6 quoted lines
> From: Elijah Newren <newren@gmail.com>
> 
> Commit c0582c53bcf4e83bba70e1ad23abbad31f96ebc8 introduced logic to just
> omit tags that point to tree objects.  However, a case was missed
> resulting in a tag being output which pointed at "mark :0", which would
> cause fast-import to crash.

Do we really want to disallow tags pointing to trees? There is at least one well-known case in use (kernel v2.6.11).

Also, (and I haven't investigated at all), this sounds like the same issue we have with tags pointing to tags. IOW, everything referenceable should be given a mark, but it is not currently. I posted a "how about this" patch for the tag case here:

  http://article.gmane.org/gmane.comp.version-control.git/119245

but I never got around to following it up with tests. Could you do something similar for the tree case?

-Peff
Previous: newren@gmail.comNext: Elijah Newren
Message 3 of 14 in “A few fast-export fixups”
  1. newren@gmail.comJun 20, 2009
  2. 1/7 fast-export: Omit tags that tag treesnewren@gmail.com, Jun 20, 2009
  3. Jeff KingJun 20, 2009
  4. Elijah NewrenJun 20, 2009
  5. Jeff KingJun 20, 2009
  6. 2/7 Modify fast-export testcase to check that we correctly omit tags of treesnewren@gmail.com, Jun 20, 2009
  7. Stephen BoydJun 21, 2009
  8. Johannes SixtJun 21, 2009
  9. Elijah NewrenJun 22, 2009
  10. 3/7 fast-export: Make sure we show actual ref names instead of "(null)"newren@gmail.com, Jun 20, 2009
  11. 4/7 fast-export: Do parent rewriting to avoid dropping relevant commitsnewren@gmail.com, Jun 20, 2009
  12. 5/7 fast-export: Add a --tag-of-filtered-object option for newly dangling tagsnewren@gmail.com, Jun 20, 2009
  13. 6/7 Add new fast-export testcasesnewren@gmail.com, Jun 20, 2009
  14. 7/7 fast-export: Document the fact that git-rev-list arguments are acceptednewren@gmail.com, Jun 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.