Re: [PATCH 2/7] Modify fast-export testcase to check that we correctly omit tags of trees

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 21, 2009, 06:17 UTC
Message-ID: <200906210817.51520.j6t@kdbg.org>
In-Reply-To: <1245472623-28103-3-git-send-email-newren@gmail.com>

On Samstag, 20. Juni 2009, newren@gmail.com wrote:

Show 8 quoted lines

> -test_expect_success 'tree_tag'        'git fast-export tree_tag'
> +test_expect_success 'tree_tag'        '
> +	mkdir result &&
> +	cd result &&
> +	git init &&
> +	cd ..
> +	git fast-export tree_tag | (cd result && git fast-import)
> +'

You should make this

test_expect_success 'tree_tag' '
	mkdir result &&
	(cd result && git init) &&
	git fast-export tree_tag > fe-stream &&
	(cd result && git fast-import < fe-stream)
'

in order to (1) not remain in the wrong directory if git init fails, and (2) to catch failures in git fast-export.

-- Hannes