Re: [RFC/PATCH 4/4] grep: obey --textconv for the case rev:path

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Feb 8, 2013, 11:27 UTC
Message-ID: <5114E130.6060902@drmicha.warpmail.net>
In-Reply-To: <7v4nho9f28.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 07.02.2013 19:03:

Show 17 quoted lines

> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>>>> (cd t && git grep GET_SHA1_QUIETLY HEAD:../cache.h)
>>>> ../HEAD:../cache.h:#define GET_SHA1_QUIETLY        01
>>>
>>> Yuck.
>>
>> And even more yuck:
>>
>> (cd t && git grep --full-name GET_SHA1_QUIETLY HEAD:../cache.h)
>> HEAD:../cache.h:#define GET_SHA1_QUIETLY        01
>>
>> Someone does not expect a "rev:" to be in there, it seems ;)
> 
> I think stepping outside of $(cwd) is an afterthought the code does
> not anticipate.
>

Well, we do resolve relative paths correctly, and there are even some "chdir" in the code path. It's just that the output label is incorrect.

Michael