Re: [WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

From: Jeff King <peff@peff.net>
Date: Feb 5, 2013, 20:11 UTC
Message-ID: <20130205201106.GA29248@sigill.intra.peff.net>
In-Reply-To: <5111317E.8060906@drmicha.warpmail.net>

On Tue, Feb 05, 2013 at 05:21:18PM +0100, Michael J Gruber wrote:

Show 8 quoted lines

> Thanks Jeff, that helps a lot! It covers "grep expr" and "grep expr rev
> -- path" just fine. I'll look into "grep expr rev:path" which does not
> work yet because of an empty driver.
> 
> I also have "show --textconv" covered and a suggestion for "cat-file
> --textconv" (to work without a textconv filter).
> 
> Expect a mini-series soon :)

Cool, I'm glad it helped. It would be great if diff_filespec and grep_source could grow together into a unified object. One of the gross things about the patch I posted is that we will now sometimes read the file/blob data via grep_source_load, and sometimes via diff_populate_filespec. They _should_ be equivalent, but in an ideal world, they would be the same code path.

That may be too much to tackle for your series, though (I wanted to do it when I factored out grep_source, but backed off for the same reason).

The "grep expr rev:path" fix should look something like this:

diff --git a/builtin/grep.c b/builtin/grep.c
index 915c8ef..cdc7d32 100644
--- a/builtin/grep.c
+++ b/builtin/grep.c
@@ -820,13 +820,17 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
 	for (i = 0; i < argc; i++) {
 		const char *arg = argv[i];
 		unsigned char sha1[20];
+		struct object_context oc;
 		/* Is it a rev? */
-		if (!get_sha1(arg, sha1)) {
+		if (!get_sha1_with_context(arg, sha1, &oc)) {
 			struct object *object = parse_object(sha1);
 			if (!object)
 				die(_("bad object %s"), arg);
 			if (!seen_dashdash)
 				verify_non_filename(prefix, arg);
+			/* oops, we need something that will remember oc.path
+			 * here, so that we can pass it along to
+			 * grep_source_init  */
 			add_object_array(object, arg, &list);
 			continue;
 		}

But you'll have to replace the object_array with something more
featureful, I think.

-Peff