Re: [RFC] Add a new email notification script to "contrib"

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Nov 22, 2012, 07:32 UTC
Message-ID: <50ADD521.8020909@alum.mit.edu>
In-Reply-To: <CACBZZX4gzgTZCk78PYpYHnKdwQ0vScoLz02tuAuUQRXVVXSLVg@mail.gmail.com>

On 11/08/2012 04:38 PM, Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

> On Thu, Nov 8, 2012 at 1:17 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>> On 11/08/2012 12:39 PM, Ævar Arnfjörð Bjarmason wrote:
>>> But in addition to that we have our own custom E-Mail notification
>>> scripts for:
>>>
>>>  * People can subscribe to changes to certain files. I.e. if you
>>>    modify very_important.c we'll send an E-Mail to a more widely seen
>>>    review list.
>>>
>>>  * Invididuals can also edit a config file to watch individual files /
>>>    glob patterns of files, e.g. src/main.c or src/crypto*
>>

[...]

> 
> I think just sending the individual patch e-mails to all people who
> subscribe to paths that got changed in that patch that match their
> watchlist makes sense.

I forgot to mention, but Environment.get_revision_recipients() has all the information needed to implement such a policy. You could override this method in your own Environment class to get the behavior that you want.

> That script *also* supports sending the whole batch of patches pushed
> in that push to someone watching any file that got modified in one of
> the patches, in case you also want to get other stuff pushed in pushes
> for files you're interested in.

This is not yet possible without more intrusive code changes.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/