Re: [RFC] Add a new email notification script to "contrib"

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Jul 16, 2012, 19:05 UTC
Message-ID: <500465E3.8040501@alum.mit.edu>
In-Reply-To: <7vtxx738dz.fsf@alter.siamese.dyndns.org>

On 07/16/2012 07:47 PM, Junio C Hamano wrote:

Show 13 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> It's already supported:
>>
>>      git config hooks.announcelist \
>>          "nosy@example.com, overwhelmed@example.com, phb@example.com"
>>      git config hooks.refchangelist \
>>          "nosy@example.com, overwhelmed@example.com"
>>      git config hooks.commitlist "nosy@example.com"
>
> Sad.  Is the "post-recieve email" squatting on the _whole_ hooks.*
> namespace, not postreceiveemailhook.* or something more reasonably
> limited?

Yes. I didn't like this either, but I copied this aspect of the old script in the interest of compatibility.

If we want to change this, now would be a good time, before the new script starts using more of the hooks namespace. One could choose a new namespace and deprecate the old one, optionally in multiple steps:

1. Only read new options from new namespace; read old options from new 
namespace or (if the new names are not set) falling back to the old 
namespace.

2. Deprecate the old namespace, emitting warnings if the old names are 
still set but continuing to use them.

3. Stop supporting the old namespace, but emit warnings if the old names 
are still set.

4. Stop looking in the old namespace altogether.

Though, given that hook scripts have to be enabled/upgraded per-repository, usually on a central server, probably doing only steps 2 and 4 would be enough.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/