Re: [PATCH v4 09/14] remote-testgit: report success after an import

From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Nov 2, 2012, 16:23 UTC
Message-ID: <5093F37D.7070705@gmail.com>
In-Reply-To: <CAMP44s2T7iOdn6mWXqcUw97d8_-=pR=7ZQ5t_ygPGOphXW5cQw@mail.gmail.com>

On 11/02/2012 05:19 PM, Felipe Contreras wrote:

Show 16 quoted lines

>
> [SNIP]
>
> As things are the options are:
> 
> 1) Remove this code and move to POSIX sh. People looking for reference
> might scratch their heads as to why 'git push' is not showing the
> update.
> 2) Keep this code and remain in bash.
> 
> Until we have a:
> 
> 3) Replace this code with a clean POSIX sh alternative
> 
> I would rather vote for 2)
>

That's perfectly fine with me, now that you've explained the rationale for requiring bash in the first place (maybe adding a comment to the script or the commit messages that reports this rationale for choosing to require bash might be worthwhile; but it's no big deal anyway).

Thanks,
  Stefano