Re: [PATCH v4 04/14] Add new simplified git-remote-testgit
- From
Jeff King <peff@peff.net>
- Date
- Nov 2, 2012, 14:00 UTC
- Message-ID
- <20121102140017.GA12040@sigill.intra.peff.net>
- In-Reply-To
- <5093D0DD.3050801@gmail.com>
On Fri, Nov 02, 2012 at 02:55:41PM +0100, Stefano Lattarini wrote:
Show 9 quoted lines
> > --- /dev/null > > +++ b/git-remote-testgit > > @@ -0,0 +1,62 @@ > > +#!/bin/bash > > > I think git can't assume the existence of bash unconditionally, neither > in its scripts, nor in its tests (the exception being the tests on > bash completion, of course). This script probably need to be re-written > to be a valid POSIX shell script.
No, we can't assume bash. But this is replacing a script written in python, which we also can't assume. So if it were optional, and skipped gracefully when bash was not available, that would be OK. Of course if it could be done in portable bourne shell, that would be even better (I haven't looked closely, but your comments all seem reasonable).
-Peff