git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] gitk: handle --full-diff correctly

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Oct 29, 2012, 06:52 UTC
Message-ID
<508E27A9.60105@viscovery.net>
In-Reply-To
<1351185801-18543-3-git-send-email-felipe.contreras@gmail.com>
Am 10/25/2012 19:23, schrieb Felipe Contreras:
> Otherwise the files are missing from the diff, and the list of files.
> 
> We do this by creating a limitdiffs variable specific for the view which
> can be turned of by using --full-diff.

It would be very helpful if you described the problem. "Try it yourself" is not the answer. In particular, what does "correctly" mean in this context? Isn't the subject more like "gitk: handle --full-diff" in the sense that it wasn't handled at all previously and it did what it happened to do?

The patch breaks gitk's builtin "limit to listed paths" option - with the patch, the option is only honored at startup, but not when it is changed during the session when --full-diff is not given. Don't know what should happen if it is given.

-- Hannes
Previous: Felipe Contreras
Message 5 of 5 in “gitk: handle --full-diff corectly”
  1. 0/2 gitk: handle --full-diff corectlyFelipe Contreras, Oct 25, 2012
  2. 1/2 gitk: simplify file filteringFelipe Contreras, Oct 25, 2012
  3. Johannes SixtOct 29, 2012
  4. 2/2 gitk: handle --full-diff correctlyFelipe Contreras, Oct 25, 2012
  5. Johannes SixtOct 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.