git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] gitk: simplify file filtering

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Oct 29, 2012, 06:46 UTC
Message-ID
<508E264C.5080005@viscovery.net>
In-Reply-To
<1351185801-18543-2-git-send-email-felipe.contreras@gmail.com>
Am 10/25/2012 19:23, schrieb Felipe Contreras:
> git diff is perfectly able to do this with '-- files', no need for
> manual filtering.

It would have been very useful if you summarized what the code did before this change.

As for the change itself, it seems to make sense to use git diff's path limiting instead of some home-grown method.

-- Hannes
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 5 in “gitk: handle --full-diff corectly”
  1. 0/2 gitk: handle --full-diff corectlyFelipe Contreras, Oct 25, 2012
  2. 1/2 gitk: simplify file filteringFelipe Contreras, Oct 25, 2012
  3. Johannes SixtOct 29, 2012
  4. 2/2 gitk: handle --full-diff correctlyFelipe Contreras, Oct 25, 2012
  5. Johannes SixtOct 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.