From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 29 Oct 2012 06:52:25 GMT
Subject: Re: [PATCH 2/2] gitk: handle --full-diff correctly
Message-ID: <508E27A9.60105@viscovery.net>
In-Reply-To: <1351185801-18543-3-git-send-email-felipe.contreras@gmail.com>

Am 10/25/2012 19:23, schrieb Felipe Contreras:
> Otherwise the files are missing from the diff, and the list of files.
> 
> We do this by creating a limitdiffs variable specific for the view which
> can be turned of by using --full-diff.

It would be very helpful if you described the problem. "Try it yourself"
is not the answer. In particular, what does "correctly" mean in this
context? Isn't the subject more like "gitk: handle --full-diff" in the
sense that it wasn't handled at all previously and it did what it happened
to do?

The patch breaks gitk's builtin "limit to listed paths" option - with the
patch, the option is only honored at startup, but not when it is changed
during the session when --full-diff is not given. Don't know what should
happen if it is given.

-- Hannes